Re: [PATCH v4 2/2] dt-bindings: usb: rt1711h device tree binding document

From: Rob Herring
Date: Mon Mar 26 2018 - 18:24:01 EST


On Tue, Mar 20, 2018 at 05:15:04PM +0800, ShuFan Lee wrote:
> From: ShuFan Lee <shufan_lee@xxxxxxxxxxx>
>
> Add device tree binding document for Richtek RT1711H Type-C chip driver
>
> Signed-off-by: ShuFan Lee <shufan_lee@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/usb/richtek,rt1711h.txt | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/richtek,rt1711h.txt
>
> changelogs between v2 & v3
> - add dt-bindings for rt1711h typec driver
>
> diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.txt b/Documentation/devicetree/bindings/usb/richtek,rt1711h.txt
> new file mode 100644
> index 000000000000..7da4dac78ea7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.txt
> @@ -0,0 +1,30 @@
> +Richtek RT1711H TypeC PD Controller.
> +
> +Required properties:
> + - compatible : Must be "richtek,rt1711h".
> + - reg : Must be 0x4e, it's slave address of RT1711H.
> +
> +Recommended properties :
> + - interrupt-parent : the phandle for the interrupt controller that
> + provides interrupts for this device.
> + - interrupts : <a b> where a is the interrupt number and b represents an
> + encoding of the sense and level information for the interrupt.
> +
> +Optional properties :
> + - rt,intr-gpios : IRQ GPIO pin that's connected to RT1711H interrupt.
> + if interrupt-parent & interrupts are not defined, use this property instead.

Drop this. You should simply always have interrupts property.

Rob