Re: [PATCH v2 2/2] dt-bindings: phy-qcom-qmp: Add UFS phy compitable string for sdm845

[cang]

On 2018-03-26 23:00, Vivek Gautam wrote:
> On 3/21/2018 11:07 AM, Can Guo wrote:
> > Update the compatible string for UFS QMP PHY on SDM845.
> >
> > Signed-off-by: Can Guo <cang@xxxxxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt 
> > b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> > index cef8765..6e68a6d 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> > +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> > @@ -11,7 +11,8 @@ Required properties:
> >   	       "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996,
> >   	       "qcom,qmp-v3-usb3-phy" for USB3 QMP V3 phy,
> >   	       "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845,
> > -	       "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on 
> > sdm845.
> > +	       "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on 
> > sdm845,
> > +	       "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845.
>
> We also need an entry for 'ref_aux' clock in the clock names for this 
> phy.
> Please add that.
> With that,
> Reviewed-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>
>
> Thanks
> Vivek.

I realized that 'ref_aux' is not needed in the driver, shall remove it 
from the PHY driver.

Thanks
Can.

> >      - reg: offset and length of register set for PHY's common serdes 
> > block.