Re: Linux 3.18.102
From: Greg KH
Date: Tue Mar 27 2018 - 03:53:41 EST
On Tue, Mar 27, 2018 at 04:31:49PM +0900, Seung-Woo Kim wrote:
>
>
> On 2018ë 03ì 27ì 16:05, Greg KH wrote:
> > On Tue, Mar 27, 2018 at 10:40:33AM +0900, Seung-Woo Kim wrote:
> >> Hello,
> >>
> >> Until 3.18.102, it looks like following patch series for v4l2 seems missed.
> >>
> >> 273caa2 media: v4l2-compat-ioctl32.c: make ctrl_is_pointer work for subdevs
> >> a1dfb4c media: v4l2-compat-ioctl32.c: refactor compat ioctl32 logic
> >> d83a824 media: v4l2-compat-ioctl32.c: don't copy back the result for
> >> certain errors
> >> 169f24c media: v4l2-compat-ioctl32.c: drop pr_info for unknown buffer type
> >> a751be5 media: v4l2-compat-ioctl32.c: copy clip list in put_v4l2_window32
> >> b8c601e media: v4l2-compat-ioctl32.c: fix ctrl_is_pointer
> >> 8ed5a59 media: v4l2-compat-ioctl32.c: copy m.userptr in put_v4l2_plane32
> >> 333b1e9 media: v4l2-compat-ioctl32.c: avoid sizeof(type)
> >> 486c521 media: v4l2-compat-ioctl32.c: move 'helper' functions to
> >> __get/put_v4l2_format32
> >> b7b957d media: v4l2-compat-ioctl32.c: fix the indentation
> >> 3ee6d04 media: v4l2-compat-ioctl32.c: add missing VIDIOC_PREPARE_BUF
> >> 181a4a2 media: v4l2-ioctl.c: don't copy back the result for -ENOTTY
> >
> > That is correct.
> >
> >> Any plan to apply the series?
> >
> > Do you have a backported version of this series that will apply to that
> > kernel tree? If so, I'll be glad to apply it but I'm pretty sure the
> > reason I did not apply them was because they did not apply correctly.
>
> I dit not do it myself. I just checked the series is applied on other
> stable trees.
Yes because those trees needed that series. Also, 3.18.y is barely
alive, if you need to rely on this kernel tree for a device, you are
already maintaining it yourself, right?
> > Also, are you even sure you need these patches for 3.18.y? Do you have
> > a v4l2 device that relies on these fixes?
>
> I've just expected A-34624167 is also fixed from other ARM64 devices
> based on 3.18.y.
What is "A-34624167"?
Again, do you have a v4l2 device that uses this interface that needs
these fixes? In looking at the 3.18.y tree, that's a very small list of
devices that are very old and rare from what I remember.
And if you do have such a device, can you just move to 4.4.y instead?
If you need these patches on 3.18.y, I'll be glad to apply them if you
provide a backported series that you can verify work for you.
thanks,
greg k-h