Re: dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7

From: Geert Uytterhoeven
Date: Tue Mar 27 2018 - 04:21:32 EST


Hi Sebastian,

On Tue, Mar 27, 2018 at 10:12 AM, Sebastian Ott
<sebott@xxxxxxxxxxxxxxxxxx> wrote:
> commit 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 broke usage of dma
> allocations specifying __GFP_ZERO by silently removing that flag.

How did it break? The flag is now always added.

> Why should "the memory returned [] always be zeroed."?

To avoid leaking information.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds