Re: [PATCH v4 2/2] mfd: rk808: Add restart functionality

[Lee Jones]

On Fri, 16 Mar 2018, Daniel Schultz wrote:

> When using Rockchip SoCs with rk805/808/818 PMICs, restarts are realized by
> setting the reset registers in the "Clock and Reset Unit".
> 
> Now, the driver can trigger a restart in the PMIC. Like the
> shutdown function, the restart is bound to an independent
> "rockchip,system-reset-controller" devicetree property can easily
> enabled by adding this.
> 
> Signed-off-by: Daniel Schultz <d.schultz@xxxxxxxxx>
> ---
> Changes:
> 	v2: Re-submit with recipients from Rockchip.
> 	v3: - Added devicetree property to enable the PMIC reset seperate from 
> 	      "rockchip,system-power-controller".
> 	    - Dropped the first patch of this serie.
> 	v4: Splitted refactoring and the new reset feature.
> 
>  drivers/mfd/rk808.c       | 58 ++++++++++++++++++++++++++++++++++++++++++-----
>  include/linux/mfd/rk808.h |  1 +
>  2 files changed, 53 insertions(+), 6 deletions(-)

Both patches look okay to me.

It would be good to obtain an Ack or two from the Rockchip guys though.

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog