Re: [PATCH v2] mm/page_owner: ignore everything below the IRQ entry point

From: Maninder Singh
Date: Tue Mar 27 2018 - 08:31:31 EST


Hi Andrew,

>filter_irq_stacks()ÂisÂtooÂlargeÂtoÂbeÂinlined.
Â
Ok we are thinking to move definations in kernel/stacktrace.c
as a normal global function.
Â

>in_irqentry_text()ÂisÂprobablyÂtooÂlargeÂtoÂbeÂinlinedÂasÂwell,Âand
>shouldÂreturnÂbool.

We can declare it as static funciton in kernel/stacktrace.c as its user
is only filter_irq_stacks.
Â
>DeclarationsÂforÂ__irqentry_text_startÂandÂfriendsÂalreadyÂexistÂin
>include/asm-generic/sections.hÂ(and,ÂforÂsomeÂreason,ÂalsoÂin
>arch/arm/include/asm/traps.h)ÂandÂshouldÂnotÂbeÂduplicatedÂin
>include/linux/stacktrace.h.

Ok, done.

Sending new patch with fixes.

Thanks.
Maninder Singh



Â
Â