Re: [PATCH] net/ncsi: check for null return from call to nla_nest_start

From: David Miller
Date: Tue Mar 27 2018 - 10:39:20 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Mon, 26 Mar 2018 12:27:12 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The call to nla_nest_start calls nla_put which can lead to a NULL
> return so it's possible for attr to become NULL and we can potentially
> get a NULL pointer dereference on attr. Fix this by checking for
> a NULL return.
>
> Detected by CoverityScan, CID#1466125 ("Dereference null return")
>
> Fixes: 955dc68cb9b2 ("net/ncsi: Add generic netlink family")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied, but...

Colin, please start marking your Subject lines properly with "[PATCH
net-next]" for patches targetting net-next as opposed to net.

Thank you.