Re: [PATCH v6 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties.

From: Rob Herring
Date: Tue Mar 27 2018 - 11:08:35 EST


On Mon, Mar 26, 2018 at 11:52:10AM +0200, Enric Balletbo i Serra wrote:
> Hardware needs a delay between setting an initial (non-zero) PWM and
> enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies
> this delay in milli seconds. Hardware also needs a delay between disabing
> the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms
> is this delay in milli seconds.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> Acked-by: Pavel Machek <pavel@xxxxxx>
> Acked-by: Thierry Reding <thierry.reding@xxxxxxxxx>
> ---
> Based on the original Huang Lin <hl@xxxxxxxxxxxxxx> work.
> Changes since v5:
> - Add Acked-by: Thierry Reding <thierry.reding@xxxxxxxxx>
> - CC DT mainling list (for some reason dropped at some point, my
> fault)
> Changes since v4:
> - Rebase on top of mainline.
> Changes since v3:
> - Replace us for ms.
> - Add Acked-by: Pavel Machek <pavel@xxxxxx>
> Changes since v2:
> - Use separate properties (Rob Herring)
> Changes since v1:
> - As suggested by Daniel Thompson
> - Do not assume power-on delay and power-off delay will be the same
> ---
> Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 ++++++
> 1 file changed, 6 insertions(+)

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>