Re: [PATCH v3 2/6] phy: qcom-qusb2: Fix crash if nvmem cell not specified

[Evan Green]

On Thu, Mar 22, 2018 at 11:13 PM Manu Gautam <mgautam@xxxxxxxxxxxxxx> wrote:

> Driver currently crashes due to NULL pointer deference
> while updating PHY tune register if nvmem cell is NULL.
> Since, fused value for Tune1/2 register is optional,
> we'd rather bail out.

> Fixes: ca04d9d3e1b1 ("phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom
chips")
> Reviewed-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>
> Cc: stable <stable@xxxxxxxxxxxxxxx> # 4.14+
> Signed-off-by: Manu Gautam <mgautam@xxxxxxxxxxxxxx>
> ---
>   drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 ++++
>   1 file changed, 4 insertions(+)


Reviewed-by: Evan Green <evgreen@xxxxxxxxxxxx>