Re: [PATCH] RDMA/hns: ensure for-loop actually iterates and free's buffers

From: Jason Gunthorpe
Date: Tue Mar 27 2018 - 17:08:11 EST


On Mon, Mar 26, 2018 at 04:10:18PM +0100, Colin Ian King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The current for-loop zeros variable i and only loops once, hence
> not all the buffers are free'd. Fix this by setting i correctly.
>
> Detected by CoverityScan, CID#1463415 ("Operands don't affect result")
>
> Fixes: a5073d6054f7 ("RDMA/hns: Add eq support of hip08")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> Reviewed-by: Yixian Liu <liuyixian@xxxxxxxxxx>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-rc, thanks

Jason