Re: [PATCH v2 1/4] selftests/Makefile: append a slash to env variable OUTPUT

From: Shuah Khan
Date: Tue Mar 27 2018 - 17:19:51 EST


On 03/26/2018 09:11 PM, changbin.du@xxxxxxxxx wrote:
> From: Changbin Du <changbin.du@xxxxxxxxx>
>
> The tools/build/Makefile.build use 'OUTPUT' variable as below example:
> objprefix := $(subst ./,,$(OUTPUT)$(dir)/)
>
> So it requires the 'OUTPUT' already has a slash at the end.
>
> This patch can kill below odd paths:
> make[3]: Entering directory '/home/changbin/work/linux/tools/gpio'
> CC /home/changbin/work/linux/tools/testing/selftests/gpiolsgpio.o
> CC /home/changbin/work/linux/tools/testing/selftests/gpiogpio-utils.o
> LD /home/changbin/work/linux/tools/testing/selftests/gpiolsgpio-in.o
>
> A correct path should be:
> /home/changbin/work/linux/tools/testing/selftests/gpio/lsgpio.o
>
> Signed-off-by: Changbin Du <changbin.du@xxxxxxxxx>

Are you seeing this when you run "make kselftest" - if gpio is the
only test compile that fails, it should be fixed in gpio/Makefile,
not is the common Makefile.

thanks,
-- Shuah