Re: [PATCH] exofs: Avoid VLA in structures

From: Andrew Morton
Date: Tue Mar 27 2018 - 18:11:01 EST


On Tue, 27 Mar 2018 13:39:04 -0700 Kees Cook <keescook@xxxxxxxxxxxx> wrote:

> On the quest to remove all VLAs from the kernel[1] this adjusts several
> cases where allocation is made after an array of structures that points
> back into the allocation. The allocations are changed to perform explicit
> calculations instead of using a Variable Length Array in a structure.
> Additionally, this lets Clang compile this code now, since Clang does not
> support VLAIS[2].
>
> [1] https://lkml.org/lkml/2018/3/7/621
> [2] https://lkml.org/lkml/2013/9/23/500
>
> ...
>
> I not sure the best way to test this. Kconfig implies I need special hardware?

Yeah, I was wondering about that. It's a tricky-looking patch.

Boaz, are you able to give it a spin?

Thanks.