Re: [PATCH] task_struct: Only use anon struct under randstruct plugin

[Andrew Morton]

On Tue, 27 Mar 2018 17:30:47 -0700 Kees Cook <keescook@xxxxxxxxxxxx> wrote:

> On Tue, Mar 27, 2018 at 4:03 PM, Andrew Morton
> <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > On Tue, 27 Mar 2018 14:36:09 -0700 Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> >> Reported-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> >> Fixes: 29e48ce87f1e ("task_struct: Allow randomized")
> >> Cc: stable@xxxxxxxxxxxxxxx
> >
> > Why cc:stable?
> 
> Since the padding existed in all configs, it's kind of an ugly wart
> and should likely be fixed up for 4.14 and 4.15 -stable.

That didn't tell us much :(
Documentation/process/stable-kernel-rules.rst doesn't mention "ugly
wart".

I think what you're hearing here is that this patch needs a better
changelog, please.  Not an uncommon failing, sigh.  A better
explanation of the origins of this padding and a better explanation of
the reasons for backporting the fix.