Re: [PATCH v6 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle.

From: Lee Jones
Date: Wed Mar 28 2018 - 07:12:22 EST


On Mon, 26 Mar 2018, Enric Balletbo i Serra wrote:

> Before this patch the enable signal was set before the PWM signal and
> vice-versa on power off. This sequence is wrong, at least, it is on
> the different panels datasheets that I checked, so I inverted the sequence
> to follow the specs.
>
> For reference the following panels have the mentioned sequence:
> - N133HSE-EA1 (Innolux)
> - N116BGE (Innolux)
> - N156BGE-L21 (Innolux)
> - B101EAN0 (Auo)
> - B101AW03 (Auo)
> - LTN101NT05 (Samsung)
> - CLAA101WA01A (Chunghwa)
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> Acked-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> Acked-by: Jingoo Han <jingoohan1@xxxxxxxxx>
> Acked-by: Thierry Reding <thierry.reding@xxxxxxxxx>
> ---
> Changes since v5:
> - Add Acked-by: Thierry Reding <thierry.reding@xxxxxxxxx>
> Changes since v4:
> - Rebase on top of mainline.
> - Add the acks from Daniel Thompson and Jingoo Han.
> Changes since v3:
> - List the part numbers for the panel checked (Daniel Thompson)
> Changes since v2:
> - Add this as a separate patch (Thierry Reding)
> Changes since v1:
> - None
> ---
> drivers/video/backlight/pwm_bl.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)

Enric,

Please collect all of your Acks and submit a RESEND.

I will then apply the set.

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog