Re: [PATCH v3 2/2] locking/debug: Add a master lock debugging switch

From: Waiman Long
Date: Wed Mar 28 2018 - 09:05:49 EST


On 03/27/2018 07:13 PM, Davidlohr Bueso wrote:
> On Tue, 27 Mar 2018, Waiman Long wrote:
>
>> Add a new master LOCK_DEBUGGING Kconfig option to turn on all the lock
>> debugging options except the selftests and the torture tests.
>
> For what purpose?
>
> I'm not sure we want yet another config debug option. These are all
> expert
> level configuration and honestly I would rather such users _think_ about
> what options they are enabling instead of giving them a large hammer.
>
> If enough load, this can also make boxes completely locked up for any
> sort of
> testing/debugging. I vote no.
>
> Also, CI efforts such 0-day already have the necessary scripting to
> cover the
> debug options that make sense.
>
> Thanks,
> Davidlohr

I think I misunderstood what the expectation is. I will send out an
updated patch to correct that.

Thanks,
Longman