Re: [PATCH v2 3/4] perf version: Print the compiled-in status of libraries

[Jin, Yao]

On 3/28/2018 9:10 PM, Jiri Olsa wrote:
> On Wed, Mar 28, 2018 at 10:57:07PM +0800, Jin Yao wrote:
>
> SNIP
>
> > +
> > +static void library_status(void)
> > +{
> > +	STATUS(HAVE_DWARF_SUPPORT, dwarf);
> > +	STATUS(HAVE_DWARF_GETLOCATIONS, dwarf_getlocations);
> > +	STATUS(HAVE_GLIBC_SUPPORT, glibc);
> > +	STATUS(HAVE_GTK2_SUPPORT, gtk2);
> > +	STATUS(HAVE_LIBAUDIT_SUPPORT, libaudit);
> > +	STATUS(HAVE_LIBBFD_SUPPORT, libbfd);
> > +	STATUS(HAVE_LIBELF_SUPPORT, libelf);
> > +	STATUS(HAVE_LIBNUMA_SUPPORT, libnuma);
> > +	STATUS(HAVE_LIBNUMA_SUPPORT, numa_num_possible_cpus);
> > +	STATUS(HAVE_LIBPERL_SUPPORT, libperl);
> > +	STATUS(HAVE_LIBPYTHON_SUPPORT, libpython);
> > +	STATUS(HAVE_SLANG_SUPPORT, libslang);
> > +	STATUS(HAVE_LIBCRYPTO_SUPPORT, libcrypto);
> > +	STATUS(HAVE_LIBUNWIND_SUPPORT, libunwind);
> > +	STATUS(HAVE_DWARF_SUPPORT, libdw-dwarf-unwind);
> > +	STATUS(HAVE_ZLIB_SUPPORT, zlib);
> > +	STATUS(HAVE_LZMA_SUPPORT, lzma);
> > +	STATUS(HAVE_AUXTRACE_SUPPORT, get_cpuid);
> > +	STATUS(HAVE_LIBBPF_SUPPORT, bpf);
> > +
> > +	on_off_print("on");
> > +	printf(": library is compiled-in\n");
> > +
> > +	on_off_print("OFF");
> > +	printf(": library is disabled in make configuration\n");
> > +	printf("         OR library is not installed in build environment\n");
>
> [jolsa@krava perf]$ ./perf -vv
> perf version 4.16.rc6.gcc183d
>                   dwarf: [ on  ]
>      dwarf_getlocations: [ on  ]
>                   glibc: [ on  ]
>                    gtk2: [ on  ]
>                libaudit: [ OFF ]
>                  libbfd: [ on  ]
>                  libelf: [ on  ]
>                 libnuma: [ on  ]
> numa_num_possible_cpus: [ on  ]
>                 libperl: [ on  ]
>               libpython: [ on  ]
>                libslang: [ on  ]
>               libcrypto: [ on  ]
>               libunwind: [ on  ]
>      libdw-dwarf-unwind: [ on  ]
>                    zlib: [ on  ]
>                    lzma: [ on  ]
>               get_cpuid: [ on  ]
>                     bpf: [ on  ]
> [ on  ]: library is compiled-in
> [ OFF ]: library is disabled in make configuration
>           OR library is not installed in build environment
>
> did anyone asked for this ^^^ help messages? I don't think they are necessary
>
> jirka

No one ask for this. Since it's not very necessary, I will remove this 
message.

Thanks
Jin Yao