Re: [PATCH V1] mfd: da9062: use core helper regmap_reg_range macros

From: Lee Jones
Date: Wed Mar 28 2018 - 11:30:04 EST


On Wed, 28 Mar 2018, Steve Twiss wrote:

> From: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
>
> Replace multi-line entries in the regmap_range arrays with single
> line macros: regmap_reg_range(). This will leave the static structure
> array entries for regmap_range unaltered. It will significantly reduce
> the line count in the DA9062/61 core file.
>
> Signed-off-by: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
>
> ---
> This patch applies against linux-next and v4.16-rc7
>
> Hi,
>
> This is a cosmetic tidy up operation. It reduces the line-count in the
> file by over 200.
>
> It will replace regmap_range[] array entries, such as this:
> {
> .range_min = DA9062AA_DEVICE_ID,
> .range_max = DA9062AA_CONFIG_ID,
> },
>
> with a single line,
> regmap_reg_range(DA9062AA_DEVICE_ID, DA9062AA_CONFIG_ID),
>
> Regards,
> Steve Twiss, Dialog Semiconductor
>
>
> drivers/mfd/da9062-core.c | 462 ++++++++++++----------------------------------
> 1 file changed, 114 insertions(+), 348 deletions(-)

Nice!

Applied, thanks.

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog