Re: [PATCH] mm: Use octal not symbolic permissions

From: Michal Hocko
Date: Wed Mar 28 2018 - 15:07:36 EST


On Wed 28-03-18 08:44:51, Joe Perches wrote:
> On Wed, 2018-03-28 at 15:06 +0200, Michal Hocko wrote:
> > On Mon 26-03-18 15:22:32, Joe Perches wrote:
> > > mm/*.c files use symbolic and octal styles for permissions.
> > >
> > > Using octal and not symbolic permissions is preferred by many as more
> > > readable.
> > >
> > > https://lkml.org/lkml/2016/8/2/1945
> > >
> > > Prefer the direct use of octal for permissions.
> > >
> > > Done using
> > > $ scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace mm/*.c
[...]
> > I hope I haven't overlooked any potential mismatch...
>
> Doubtful as the conversion is completely automated.

Ohh, I failed to see --fix-inplace option for checkpatch. I wasn't aware
that checkpatch can perform changes as well.

--
Michal Hocko
SUSE Labs