RE: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist

[Long Li]

> Subject: Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector
> blacklist
> 
> 
> Long, KY: Please confirm.
> 
> > The Windows Server 2016 iSCSI target doesn't work with the Linux
> > kernel initiator since the kernel started sending larger requests by
> > default, nor does it implement the block limits VPD page. Apply the
> > sector limit workaround for these targets.
> >
> > Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> > ---
> >  drivers/scsi/scsi_devinfo.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> > index f3b1172..5cb748a 100644
> > --- a/drivers/scsi/scsi_devinfo.c
> > +++ b/drivers/scsi/scsi_devinfo.c
> > @@ -213,7 +213,7 @@ static struct {
> >  	{"Medion", "Flash XL  MMC/SD", "2.6D", BLIST_FORCELUN},
> >  	{"MegaRAID", "LD", NULL, BLIST_FORCELUN},
> >  	{"MICROP", "4110", NULL, BLIST_NOTQ},
> > -	{"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC},
> > +	{"MSFT", "Virtual HD", NULL, BLIST_MAX_1024 | BLIST_NO_RSOC},

Ross,

What about storage_channel_properties.max_transfer_bytes returned from VSTOR_OPERATION_QUERY_PROPERTIES (in storvsc_channel_init())

Does it return correctly the maximum transfer size for iSCSI?

Long 

> >  	{"MYLEX", "DACARMRB", "*", BLIST_REPORTLUN2},
> >  	{"nCipher", "Fastness Crypto", NULL, BLIST_FORCELUN},
> >  	{"NAKAMICH", "MJ-4.8S", NULL, BLIST_FORCELUN |
> BLIST_SINGLELUN},
> 
> --
> Martin K. Petersen	Oracle Linux Engineering