Re: [PATCHv2 06/14] mm/page_alloc: Propagate encryption KeyID through page allocator

From: Michal Hocko
Date: Thu Mar 29 2018 - 07:20:43 EST


On Wed 28-03-18 19:55:32, Kirill A. Shutemov wrote:
> Modify several page allocation routines to pass down encryption KeyID to
> be used for the allocated page.
>
> There are two basic use cases:
>
> - alloc_page_vma() use VMA's KeyID to allocate the page.
>
> - Page migration and NUMA balancing path use KeyID of original page as
> KeyID for newly allocated page.

I am sorry but I am out of time to look closer but this just raised my
eyebrows. This looks like a no-go. The basic allocator has no business
in fancy stuff like a encryption key. If you need something like that
then just build a special allocator API on top. This looks like a no-go
to me.
--
Michal Hocko
SUSE Labs