Re: [PATCH 1/3] virt: vbox: Add vbg_req_free() helper function

[Hans de Goede]

Hi,

On 29-03-18 13:56, Greg Kroah-Hartman wrote:
> On Thu, Mar 29, 2018 at 01:21:14PM +0200, Hans de Goede wrote:
> > +void vbg_req_free(void *req, size_t len)
> > +{
> > +	if (!req)
> > +		return;
> > +
> > +	kfree(req);
> > +}
>
> Wait, no, this isn't ok.  Don't create wrapper functions that you never
> use except as a wrapper :(
>
> I can see someone sending me almost the indental revert patch right
> after this one gets applied...

The 2nd patch in the series changes this function to be more then
just a wrapper around kfree. As mentioned in the commit message
this is a preparation patch for that 2nd patch, the idea is that
by splitting out the patch replacing all the kfree() calls with
vbg_req_free() calls the 2nd patch becomes easier to review.

Regards,

Hans