Re: [PATCH v7 06/14] ext2, dax: introduce ext2_dax_aops

[Jan Kara]

On Wed 21-03-18 15:57:43, Dan Williams wrote:
> In preparation for the dax implementation to start associating dax pages
> to inodes via page->mapping, we need to provide a 'struct
> address_space_operations' instance for dax. Otherwise, direct-I/O
> triggers incorrect page cache assumptions and warnings.
> 
> Cc: Jan Kara <jack@xxxxxxxx>
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>

Thanks for the cleanup in the patch when setting inode ops. The patch looks
good except the same comment applies as for ext4 - please provide
ext2_dax_direct_IO() which will just bail and use it in ext2_dax_aops.

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR