Re: [PATCH 3/4] nvmet-fc: Don't use the count returned by the dma_map_sg call

From: Logan Gunthorpe
Date: Thu Mar 29 2018 - 12:38:59 EST




On 29/03/18 10:14 AM, Bart Van Assche wrote:
> On Thu, 2018-03-29 at 10:07 -0600, Logan Gunthorpe wrote:
>> + ret = fc_dma_map_sg(fod->tgtport->dev, sg, nent,
>> + ((fod->io_dir == NVMET_FCP_WRITE) ?
>> + DMA_FROM_DEVICE : DMA_TO_DEVICE));
>> + /* note: write from initiator perspective */
>
> If you have to repost this patch please remove the four superfluous parentheses.

Oh, actually, I made this change in patch 4 of this series for the next
time I post it. This allowed me to cleanup both the map and unmap
instances in the same patch.

Also, if the maintainer wants to pick up patch 3 as a bug fix I can
carry the rest in the P2PDMA series.

Thanks,

Logan