Re: [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

From: Herbert Xu
Date: Thu Mar 29 2018 - 13:06:39 EST


On Thu, Mar 29, 2018 at 06:52:34PM +0200, Andreas Gruenbacher wrote:
>
> Should rhashtable_walk_peek be kept around even if there are no more
> users? I have my doubts.

Absolutely. All netlink dumps using rhashtable_walk_next are buggy
and need to switch over to rhashtable_walk_peek. As otherwise
the object that triggers the out-of-space condition will be skipped
upon resumption.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt