Re: [PATCH] time: export nsec_to_clock_t

From: Thomas Gleixner
Date: Thu Mar 29 2018 - 15:12:04 EST


On Thu, 29 Mar 2018, Zhang Rui wrote:
> On ä, 2018-03-28 at 16:11 +0200, Arnd Bergmann wrote:
> > nsec_to_clock_t was traditionally used only in the core kernel, now
> > we
> > have a sysfs file that needs it from a loadable module, causing a
> > link-time error:
> >
> > ERROR: "nsec_to_clock_t" [drivers/thermal/thermal_sys.ko] undefined!
> >
> > This exports the function the same way that we do for related
> > interfaces.
> >
> > Fixes: 96cea33badc5 ("thermal: Add cooling device's statistics in
> > sysfs")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Thanks for the fix.
> can I take this patch through thermal tree?

Well, the question is what's the point of that?

Why does a new interface expose time in state in clock_t instead in normal
time units, e.g. nsec/usec/msec ?

That makes no sense whatsoever.

Thanks,

tglx