Re: [PATCHv3 4/7] dt-bindings: fpga: add Stratix10 SoC FPGA manager binding

[Alan Tull]

On Tue, Mar 27, 2018 at 3:20 PM,  <richard.gong@xxxxxxxxxxxxxxx> wrote:
> From: Alan Tull <atull@xxxxxxxxxx>
>
> Add a Device Tree binding for the Intel Stratix10 SoC FPGA manager.
>
> Signed-off-by: Alan Tull <atull@xxxxxxxxxx>
> ---
> v2: this patch is added in patch set version 2
> v3: change to put fpga_mgr node under firmware/svc node
> ---
>  .../bindings/fpga/intel-stratix10-soc-fpga-mgr.txt      | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt
>
> diff --git a/Documentation/devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt b/Documentation/devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt
> new file mode 100644
> index 0000000..be7cd96
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/intel-stratix10-soc-fpga-mgr.txt
> @@ -0,0 +1,17 @@
> +Intel Stratix10 SoC FPGA Manager
> +
> +Required properties:
> +The fpga_mgr node has the following mandatory property, must be located under
> +firmware/svc node.
> +
> +- compatible : should contain "intel,stratix10-soc-fpga-mgr"
> +
> +Example:
> +
> +       firmware {
> +               svc {
> +                       fpga_mgr: fpga-mgr@0 {

Shouldn't have the index.  Should be:

                            fpga_mgr: fpga-mgr {

Alan

> +                               compatible = "intel,stratix10-soc-fpga-mgr";
> +                       };
> +               };
> +       };
> --
> 2.7.4
>