Re: [PATCH] Revert "crypto/ecc: Remove stack VLA usage"
From: Kees Cook
Date: Fri Mar 30 2018 - 12:49:49 EST
On Fri, Mar 30, 2018 at 9:39 AM, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Mar 26, 2018 at 04:03:08PM -0700, Kees Cook wrote:
>> This reverts commit 14de52112ee70ca289fa77bf2d9cbc79fd2c811f.
>>
>> The solution was incomplete and inefficient. This will be fixed
>> correctly in the next patch.
>>
>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> Hmm you didn't post this to linux-crypto so it's not in patchwork.
>
> Anyway, I'd prefer if you just squashed this together with the
> subsequent patch. It's not that complex to require a revert and
> a new patch to be readable.
Sounds good, thanks!
-Kees
--
Kees Cook
Pixel Security