Re: [PATCH] nvmet: fix nvmet_execute_write_zeroes function

[Rodrigo Rosatti GalvÃo]

> Doesn't that mean your host is using this command wrong? The NLB is a
> 0's based value, we're supposed to +1 to get the correct block count.

Keith, I tested passing different values to the c (number of blocks) and 
s (64-bit LBA of first block to access) parameters, and it was failing. 
When I removed the +1, the command worked fine.

I used a simple script to validate this:

for s in {0..20}
ÂÂÂ do
ÂÂÂ ÂÂÂ ÂÂÂ for c in {0..20}
ÂÂÂ ÂÂÂ ÂÂÂ do
ÂÂÂ ÂÂÂ ÂÂÂÂÂÂÂÂÂÂÂ nvme write-zeroes /dev/nvme0 -n 10 -s $s -c $c
ÂÂÂ ÂÂÂ ÂÂÂ done
ÂÂÂ done


Is there some other way to test it?

--
Rodrigo R. GalvÃo
Intern - Linux Technology Center - IBM