Re: [v3, 1/4] powerpc: wii: Explicitly configure GPIO owner for poweroff pin
From: Michael Ellerman
Date: Sat Mar 31 2018 - 10:03:58 EST
On Fri, 2018-02-09 at 12:07:28 UTC, =?utf-8?q?Jonathan_Neusch=C3=A4fer?= wrote:
> The Hollywood chipset's GPIO controller has two sets of registers: One
> for access by the PowerPC CPU, and one for access by the ARM coprocessor
> (but both are accessible from the PPC because the memory firewall
> (AHBPROT) is usually disabled when booting Linux, today).
>
> The wii_power_off function currently assumes that the poweroff GPIO pin
> is configured for use via the ARM side, but the upcoming GPIO driver
> configures all pins for use via the PPC side, breaking poweroff.
>
> Configure the owner register explicitly in wii_power_off to make
> wii_power_off work with and without the new GPIO driver.
>
> I think the Wii can be switched to the generic gpio-poweroff driver,
> after the GPIO driver is merged.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
Patches 1, 3 and 4 applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/9cbaaec1cf0c9f4861c4c1dd65f3ed
cheers