[tip:sched/urgent] sched/cpufreq/schedutil: Fix error path mutex unlock
From: tip-bot for Jules Maselbas
Date: Sat Mar 31 2018 - 14:53:24 EST
Commit-ID: 1b5d43cfb69759d8ef8d30469cea31d0c037aed5
Gitweb: https://git.kernel.org/tip/1b5d43cfb69759d8ef8d30469cea31d0c037aed5
Author: Jules Maselbas <jules.maselbas@xxxxxxx>
AuthorDate: Thu, 29 Mar 2018 15:43:01 +0100
Committer: Ingo Molnar <mingo@xxxxxxxxxx>
CommitDate: Sat, 31 Mar 2018 20:42:38 +0200
sched/cpufreq/schedutil: Fix error path mutex unlock
This patch prevents the 'global_tunables_lock' mutex from being
unlocked before being locked. This mutex is not locked if the
sugov_kthread_create() function fails.
Signed-off-by: Jules Maselbas <jules.maselbas@xxxxxxx>
Acked-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Chris Redpath <chris.redpath@xxxxxxx>
Cc: Dietmar Eggermann <dietmar.eggemann@xxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: Mike Galbraith <efault@xxxxxx>
Cc: Patrick Bellasi <patrick.bellasi@xxxxxxx>
Cc: Stephen Kyle <stephen.kyle@xxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: nd@xxxxxxx
Link: http://lkml.kernel.org/r/20180329144301.38419-1-jules.maselbas@xxxxxxx
Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
---
kernel/sched/cpufreq_schedutil.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 7936f548e071..617c6741c525 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -625,10 +625,9 @@ fail:
stop_kthread:
sugov_kthread_stop(sg_policy);
-
-free_sg_policy:
mutex_unlock(&global_tunables_lock);
+free_sg_policy:
sugov_policy_free(sg_policy);
disable_fast_switch: