Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver
From: Neil Leeder
Date: Sun Apr 01 2018 - 01:44:50 EST
Hi Yisheng Xie,
On 3/29/2018 03:03 AM, Yisheng Xie wrote:
Hi Neil,
On 2017/8/5 3:59, Neil Leeder wrote:
+ÂÂÂ mem_resource_0 = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ÂÂÂ mem_map_0 = devm_ioremap_resource(&pdev->dev, mem_resource_0);
+
Can we use devm_ioremap instead? for the reg_base of smmu_pmu is
IMPLEMENTATION DEFINED. If the reg of smmu_pmu is inside smmu,
devm_ioremap_resource will failed and return -EBUSY, eg.:
Âsmmu reg ranges:ÂÂÂÂÂÂÂ 0x180000000 ~ 0x1801fffff
Âits smmu_pmu reg ranges:ÂÂÂ 0x180001000 ~ 0x180001fff
Just to let you know that I no longer work at Qualcomm and I won't be
able to provide updates to this patchset. I expect that others from my
former team at Qualcomm will pick up ownership.
Neil