Re: [PATCH 4.4 089/134] ARM: dts: omap3-n900: Fix the audio CODECs reset pin

From: Ben Hutchings
Date: Sun Apr 01 2018 - 16:49:49 EST


On Mon, 2018-03-19 at 19:06 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.ÂÂIf anyone has any objections, please let me know.
>
> ------------------
>
> From: "Andrew F. Davis" <afd@xxxxxx>
>
>
> [ Upstream commit 7be4b5dc7ffa9499ac6ef33a5ffa9ff43f9b7057 ]
>
> The correct DT property for specifying a GPIO used for reset
> is "reset-gpios", fix this here.

This also depends on a driver change. Please revert it for all stable
branches.

Ben.

> Fixes: 14e3e295b2b9 ("ARM: dts: omap3-n900: Add TLV320AIC3X support")
>
> Signed-off-by: Andrew F. Davis <afd@xxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> Âarch/arm/boot/dts/omap3-n900.dts |ÂÂÂÂ4 ++--
> Â1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -488,7 +488,7 @@
> Â tlv320aic3x: tlv320aic3x@18 {
> Â compatible = "ti,tlv320aic3x";
> Â reg = <0x18>;
> - gpio-reset = <&gpio2 28 GPIO_ACTIVE_HIGH>; /* 60 */
> + reset-gpios = <&gpio2 28 GPIO_ACTIVE_LOW>; /* 60 */
> Â ai3x-gpio-func = <
> Â 0 /* AIC3X_GPIO1_FUNC_DISABLED */
> Â 5 /* AIC3X_GPIO2_FUNC_DIGITAL_MIC_INPUT */
> @@ -505,7 +505,7 @@
> Â tlv320aic3x_aux: tlv320aic3x@19 {
> Â compatible = "ti,tlv320aic3x";
> Â reg = <0x19>;
> - gpio-reset = <&gpio2 28 GPIO_ACTIVE_HIGH>; /* 60 */
> + reset-gpios = <&gpio2 28 GPIO_ACTIVE_LOW>; /* 60 */
> Â
> Â AVDD-supply = <&vmmc2>;
> Â DRVDD-supply = <&vmmc2>;

--
Ben Hutchings
Software Developer, Codethink Ltd.