Re: [PATCH 1/1] drm/i915: Do not use kfree() to free kmem_cache_alloc() return value

From: Chris Wilson
Date: Wed Apr 04 2018 - 03:57:23 EST


Quoting Xidong Wang (2018-04-04 08:37:54)
> In eb_lookup_vmas(), the return value of kmem_cache_alloc() is freed
> with kfree(). I think the expected paired function is kmem_cahce_free().
>
> Signed-off-by: Xidong Wang <wangxidong_97@xxxxxxx>

That is indeed what it should be doing,

Fixes: d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr")
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx> # v4.14+
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris