Re: [PATCH 1/1] drm/i915:Do not use kfree() to free kmem_cache_alloc() return value

[Jani Nikula]

On Wed, 04 Apr 2018, Xidong Wang <wangxidong_97@xxxxxxx> wrote:
> In eb_lookup_vmas(), lut, the return value of kmem_cache_alloc(), is freed
> with kfree().I think the expected paired function is kmem_cache_free().

Agreed. But did you try to compile your patch before sending?

Fixes: d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr")
Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx> # v4.14+

BR,
Jani.

>
> Signed-off-by: Xidong Wang <wangxidong_97@xxxxxxx>
> ---
>  drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> index 8c170db..08fe476 100644
> --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> @@ -728,7 +728,7 @@ static int eb_lookup_vmas(struct i915_execbuffer *eb)
>  
>  		err = radix_tree_insert(handles_vma, handle, vma);
>  		if (unlikely(err)) {
> -			kfree(lut);
> +			kmem_cache_free(lut);
>  			goto err_obj;
>  		}

-- 
Jani Nikula, Intel Open Source Technology Center