Re: [PATCH 0/3] mmc: add support for sdhci 4.0

From: Adrian Hunter
Date: Wed Apr 04 2018 - 07:44:34 EST


On 04/04/18 13:17, Ulf Hansson wrote:
> On 4 April 2018 at 11:05, Chunyan Zhang <zhang.chunyan@xxxxxxxxxx> wrote:
>> Hi Ulf,
>>
>> Do you have some comments on this patch-set?
>
> No objections from my side of the series, however I am relying on
> Adrian's ack before I pick any of the patches.

We don't have any drivers that enable v4 mode. Really we need that, so that
we are supporting features that are actually in use. Equally some evidence
of testing would be expected.

>
> Kind regards
> Uffe
>
>>
>> Thanks,
>> Chunyan
>>
>> On 20 March 2018 at 16:36, Chunyan Zhang <zhang.chunyan@xxxxxxxxxx> wrote:
>>> From the SD host controller version 4.0 on, SDHCI implementation either
>>> is version 3 compatible or version 4 mode. This patch-set covers those
>>> changes which are common for SDHCI 4.0 version, regardless of whether
>>> they are used with SD or eMMC storage devices.
>>>
>>> Chunyan Zhang (3):
>>> mmc: sdhci: add sd host v4 mode
>>> mmc: sdhci: made changes for System Address register of SDMA
>>> mmc: sdhci: add ADMA2 64-bit addressing support for V4 mode
>>>
>>> drivers/mmc/host/sdhci.c | 66 +++++++++++++++++++++++++++++++++++++-----------
>>> drivers/mmc/host/sdhci.h | 29 +++++++++++++++++----
>>> 2 files changed, 75 insertions(+), 20 deletions(-)
>>>
>>> --
>>> 2.7.4
>>>
>