Re: [PATCH v7 1/5] mm: page_alloc: remain memblock_next_valid_pfn() on arm and arm64

From: Matthew Wilcox
Date: Thu Apr 05 2018 - 07:24:30 EST


On Thu, Apr 05, 2018 at 01:04:34AM -0700, Jia He wrote:
> create mode 100644 include/linux/arm96_common.h

'arm96_common'?! No. Just no.

The right way to share common code is to create a header file (or use
an existing one), either in asm-generic or linux, with a #ifdef CONFIG_foo
block and then 'select foo' in the arm Kconfig files. That allows this
common code to be shared, maybe with powerpc or x86 or ... in the future.