Re: [PATCH] trace: Fixup logic inversion on setting trace_global_clock defaults

From: Steven Rostedt
Date: Thu Apr 05 2018 - 07:48:36 EST


On Wed, 4 Apr 2018 22:24:50 +0100
Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:

> In commit 932066a15335 ("tracing: Default to using trace_global_clock if
> sched_clock is unstable"), the logic for deciding to override the
> default clock if unstable was reversed from the earlier posting. I was
> trying to reduce the width of the message by using an early return
> rather than a if-block, but reverted back to using the if-block and
> accidentally left the predicate inverted.

Hey, the inversion found some issues with global clock interacting with
lockdep, so it was a good bug to have ;-)

-- Steve