Re: [PATCH v6 2/2] dt-bindings: introduce Command DB for QCOM SoCs

[Bjorn Andersson]

On Thu 05 Apr 09:04 PDT 2018, Lina Iyer wrote:

> From: Mahesh Sivasubramanian <msivasub@xxxxxxxxxxxxxx>
> 
> Command DB provides information on shared resources like clocks,
> regulators etc., probed at boot by the remote subsytem and made
> available in shared memory.
> 
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Mahesh Sivasubramanian <msivasub@xxxxxxxxxxxxxx>
> Signed-off-by: Lina Iyer <ilina@xxxxxxxxxxxxxx>
> ---
> 
> Changes in v6:
> 	- Move to bindings/reserved-memory
> 	- Remove indirection address and use only the actual reserved
> 	  memory
> 
> Changes in v4:
> 	- Fix unwanted capitalization
> 	- Add reg property
> ---
>  .../bindings/reserved-memory/qcom,cmd-db.txt       | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt
> 
> diff --git a/Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt b/Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt
> new file mode 100644
> index 000000000000..d808ada474c1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt
> @@ -0,0 +1,37 @@
> +Command DB
> +---------
> +
> +Command DB is a database that provides a mapping between resource key and the
> +resource address for a system resource managed by a remote processor. The data
> +is stored in a shared memory region and is loaded by the remote processor.
> +
> +Some of the Qualcomm Technologies Inc SoC's have hardware accelerators for
> +controlling shared resources. Depending on the board configuration the shared
> +resource properties may change. These properties are dynamically probed by the
> +remote processor and made available in the shared memory.
> +
> +The bindings for Command DB is specified in the reserved-memory section in
> +devicetree. The devicetree representation of the command DB driver should be:
> +
> +Properties:
> +- compatible:
> +	Usage: required
> +	Value type: <string>
> +	Definition: Should be "qcom,cmd-db"
> +
> +- reg:
> +	Usage: required
> +	Value type: <prop encoded array>
> +	Definition: The register address that points to the location of the
> +		    Command DB in memory. Additionally, specify the address
> +		    and size of the actual lacation in memory.

The reg doesn't reference the indirection registers anymore, please
update this.

Apart from this, you have my:

Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Regards,
Bjorn