Re: [PATCH 4.4 63/97] md/raid10: skip spare disk as first disk

From: Greg Kroah-Hartman
Date: Fri Apr 06 2018 - 03:32:40 EST


On Tue, Apr 03, 2018 at 10:32:09PM +0100, Ben Hutchings wrote:
> On Fri, 2018-03-23 at 10:54 +0100, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Shaohua Li <shli@xxxxxx>
> >
> >
> > [ Upstream commit b506335e5d2b4ec687dde392a3bdbf7601778f1d ]
> >
> > Commit 6f287ca(md/raid10: reset the 'first' at the end of loop) ignores
> > a case in reshape, the first rdev could be a spare disk, which shouldn't
> > be accounted as the first disk since it doesn't include the offset info.
> >
> > Fix: 6f287ca(md/raid10: reset the 'first' at the end of loop)
>
> But that commit hasn't been applied to 4.4-stable. It probably should
> be, since it fixes another instance of the problem in the run()
> function. Take care not to add the wrongly placed assignment
> in raid10_start_reshape().

Thanks, now fixed up.

greg k-h