Re: [PATCH 05/20] afs: Implement @sys substitution handling

From: David Howells
Date: Fri Apr 06 2018 - 04:13:13 EST


Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:

> lookup_one_len() seriously depends upon exclusive lock

In the code it says:

WARN_ON_ONCE(!inode_is_locked(base->d_inode));

which checks i_rwsem, but in the banner comment it says:

* The caller must hold base->i_mutex.

is one of these wrong?

David