Re: [PATCH v4 4/9] vsprintf: Consolidate handling of unknown pointer specifiers
From: Rasmus Villemoes
Date: Fri Apr 06 2018 - 09:17:29 EST
On 2018-04-06 13:43, Petr Mladek wrote:
> On Thu 2018-04-05 16:55:35, Joe Perches wrote:
>> On Thu, 2018-04-05 at 16:45 -0700, Joe Perches wrote:
>>> On Thu, 2018-04-05 at 16:25 +0200, Rasmus Villemoes wrote:
>>>> Even just git grep -1 -E '%p"$' finds %pt and %po
>>>> which should get fixed before somebody claims those extensions.
>>>
>>> Neither %pt nor %po is used in a vsprintf
>>> in the kernel.
>>
>> Nope, you are right, both are defectively used in the
>> kernel via string concatenation.
>
> Ah, I see.
Yes, that was the point of that particular grep pattern with context. I
sent patches three years ago and several pings, but despite an email
telling me it would be picked up "for the next release" nothing has
happened, so I've just been waiting for someone to implement a %po.
> Otherwise, the changes make perfect sense. Are you going to send
> them as proper patches, please?
Good luck. Unless Petr will be taking them through the printk tree?
Rasmus