Re: [PATCH] qla2xxx: correctly shift host byte

From: Bart Van Assche
Date: Fri Apr 06 2018 - 11:33:42 EST


On Fri, 2018-04-06 at 09:52 +0200, Johannes Thumshirn wrote:
> The host byte has to be shifted by 16 not 6.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index 89f93ebd819d..49d67e1d571f 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -2368,7 +2368,7 @@ qla25xx_process_bidir_status_iocb(scsi_qla_host_t *vha, void *pkt,
> bsg_job->reply_len = sizeof(struct fc_bsg_reply);
> /* Always return DID_OK, bsg will send the vendor specific response
> * in this case only */
> - sp->done(sp, DID_OK << 6);
> + sp->done(sp, DID_OK << 16);
>
> }

Hello Johannes,

Had you noticed the following statements? I think the "<< 1" should be removed
from these statements.

$ git grep 'SAM_STAT.*<< 1'
drivers/scsi/qla2xxx/qla_isr.c: cmd->result |= SAM_STAT_CHECK_CONDITION << 1;
drivers/scsi/qla2xxx/qla_isr.c: cmd->result |= SAM_STAT_CHECK_CONDITION << 1;
drivers/scsi/qla2xxx/qla_isr.c: cmd->result |= SAM_STAT_CHECK_CONDITION << 1;

Thanks,

Bart.