Re: [PATCH resend] mm/page_alloc: fix comment is __get_free_pages

From: Andrew Morton
Date: Fri Apr 06 2018 - 15:58:53 EST


On Fri, 6 Apr 2018 12:02:36 +0200 Michal Hocko <mhocko@xxxxxxxxxx> wrote:

> On Wed 29-11-17 17:04:46, Michal Hocko wrote:
> [...]
> > From 000bb422fe07adbfa8cd8ed953b18f48647a45d6 Mon Sep 17 00:00:00 2001
> > From: Michal Hocko <mhocko@xxxxxxxx>
> > Date: Wed, 29 Nov 2017 17:02:33 +0100
> > Subject: [PATCH] mm: drop VM_BUG_ON from __get_free_pages
> >
> > There is no real reason to blow up just because the caller doesn't know
> > that __get_free_pages cannot return highmem pages. Simply fix that up
> > silently. Even if we have some confused users such a fixup will not be
> > harmful.
> >
> > Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>
>
> Andrew, have we reached any conclusion for this? Should I repost or drop
> it on the floor?

I actually thought we'd settled on something and merged it. hrm.

Please send a fresh patch sometime?