Re: [PATCH] selftests/livepatch: introduce tests

From: Josh Poimboeuf
Date: Fri Apr 06 2018 - 22:37:05 EST


On Wed, Mar 28, 2018 at 03:49:48PM -0400, Joe Lawrence wrote:
> Add a few livepatch modules and simple target modules that the included
> regression suite can run tests against.
>
> Signed-off-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx>
> ---
> lib/Kconfig.debug | 12 +
> lib/Makefile | 2 +
> lib/livepatch/Makefile | 18 +
> lib/livepatch/test_klp_atomic_replace.c | 69 +++
> lib/livepatch/test_klp_callbacks_busy.c | 43 ++
> lib/livepatch/test_klp_callbacks_demo.c | 132 ++++++
> lib/livepatch/test_klp_callbacks_demo2.c | 104 ++++
> lib/livepatch/test_klp_callbacks_mod.c | 24 +
> lib/livepatch/test_klp_livepatch.c | 62 +++
> tools/testing/selftests/Makefile | 1 +
> tools/testing/selftests/livepatch/Makefile | 8 +
> tools/testing/selftests/livepatch/config | 1 +
> tools/testing/selftests/livepatch/functions.sh | 202 ++++++++
> .../testing/selftests/livepatch/test-callbacks.sh | 526 +++++++++++++++++++++
> .../testing/selftests/livepatch/test-livepatch.sh | 177 +++++++
> .../selftests/livepatch/test-shadow-vars.sh | 13 +
> 16 files changed, 1394 insertions(+)
> create mode 100644 lib/livepatch/Makefile
> create mode 100644 lib/livepatch/test_klp_atomic_replace.c
> create mode 100644 lib/livepatch/test_klp_callbacks_busy.c
> create mode 100644 lib/livepatch/test_klp_callbacks_demo.c
> create mode 100644 lib/livepatch/test_klp_callbacks_demo2.c
> create mode 100644 lib/livepatch/test_klp_callbacks_mod.c
> create mode 100644 lib/livepatch/test_klp_livepatch.c
> create mode 100644 tools/testing/selftests/livepatch/Makefile
> create mode 100644 tools/testing/selftests/livepatch/config
> create mode 100644 tools/testing/selftests/livepatch/functions.sh
> create mode 100755 tools/testing/selftests/livepatch/test-callbacks.sh
> create mode 100755 tools/testing/selftests/livepatch/test-livepatch.sh
> create mode 100755 tools/testing/selftests/livepatch/test-shadow-vars.sh

I love this. Nice work!

As you and Petr discussed, it would be nice to get rid of some of the
delays, and also the callback tests will be very important.

--
Josh