Re: [PATCH 2/4] arm64: usercopy: implement arch_within_stack_frames

From: Keun-O Park
Date: Sun Apr 08 2018 - 02:39:38 EST


Hi Kees,

On Thu, Apr 5, 2018 at 2:55 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> On Thu, Mar 1, 2018 at 2:19 AM, <kpark3469@xxxxxxxxx> wrote:
>> From: James Morse <james.morse@xxxxxxx>
>>
>> This implements arch_within_stack_frames() for arm64 that should
>> validate if a given object is contained by a kernel stack frame.
>>
>> Signed-off-by: James Morse <james.morse@xxxxxxx>
>> Reviewed-by: Sahara <keun-o.park@xxxxxxxxxxxxx>
>
> Looks good to me. Does this end up passing the LKDTM
> USERCOPY_STACK_FRAME_TO and USERCOPY_STACK_FRAME_FROM tests?

Yes, this passes those two LKDTM tests.
Thanks.

BR
Sahara