Re: [alsa-devel] [PATCH] ASoC: fsl_esai: Fix divisor calculation failure at lower ratio
From: Fabio Estevam
Date: Sun Apr 08 2018 - 21:34:06 EST
Hi Nicolin,
On Sun, Apr 8, 2018 at 8:57 PM, Nicolin Chen <nicoleotsuka@xxxxxxxxx> wrote:
> When the desired ratio is less than 256, the savesub (tolerance)
> in the calculation would become 0. This will then fail the loop-
> search immediately without reporting any errors.
>
> But if the ratio is smaller enough, there is no need to calculate
> the tolerance because PM divisor alone is enough to get the ratio.
>
> So a simple fix could be just to set PM directly instead of going
> into the loop-search.
>
> Reported-by: Marek Vasut <marex@xxxxxxx>
> Signed-off-by: Nicolin Chen <nicoleotsuka@xxxxxxxxx>
> Cc: Marek Vasut <marex@xxxxxxx>
If this fixes Marek's usecase then I think we should also add:
Cc: <stable@xxxxxxxxxxxxxxx>
Thanks