Re: [PATCH] tick-sched: avoid a maybe-uninitialized warning

From: Ingo Molnar
Date: Mon Apr 09 2018 - 12:18:31 EST



* Arnd Bergmann <arnd@xxxxxxxx> wrote:

> The use of bitfields seems to confuse gcc, leading to a false-positive
> warning in all compiler versions:
>
> kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit':
> kernel/time/tick-sched.c:538:2: error: 'now' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> This introduces a temporary variable to track the flags so gcc
> doesn't have to evaluate twice, eliminating the code path that
> leads to the warning.
>
> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85301
> Fixes: 1cae544d42d2 ("nohz: Gather tick_sched booleans under a common flag field")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Which tree is this against? There's no such commit either in -tip, upstream or in
-next AFAICS.

Thanks,

Ingo