Re: [PATCH] X86/VMX: Disable VMX preempition timer if MWAIT is not intercepted

[Paolo Bonzini]

On 10/04/2018 10:50, KarimAllah Ahmed wrote:
>  	WARN_ON(preemptible());
> -	if (!kvm_x86_ops->set_hv_timer)
> +	if (!kvm_x86_ops->has_hv_timer ||
> +	    !kvm_x86_ops->has_hv_timer(apic->vcpu))
>  		return false;
>  
>  	if (!apic_lvtt_period(apic) && atomic_read(&ktimer->pending))

Why not just return -ENOTSUP from vmx_set_hv_timer?

Thanks,

Paolo