Re: [PATCH] staging: comedi: cb_pcidas64: fix alignment of function parameters

From: Ian Abbott
Date: Wed Apr 11 2018 - 05:16:36 EST


On 11/04/18 06:07, Julia Lawall wrote:
On Tue, 10 Apr 2018, Gabriel Francisco Mandaji wrote:
[snip]
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index fdd81c3..631a703 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -2268,14 +2268,14 @@ static inline unsigned int dma_transfer_size(struct comedi_device *dev)
}

static u32 ai_convert_counter_6xxx(const struct comedi_device *dev,
- const struct comedi_cmd *cmd)
+ const struct comedi_cmd *cmd)

Someone has made the effort to put const on these parameters, but not on
the other similar functions. Perhaps this can be improved as well.

Perhaps, but that should be in a separate patch.

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Web: http://www.mev.co.uk/ )=-