Re: [PATCH 06/24] kexec_load: Disable at runtime if the kernel is locked down

From: Eric W. Biederman
Date: Wed Apr 11 2018 - 15:01:40 EST


David Howells <dhowells@xxxxxxxxxx> writes:

> From: Matthew Garrett <mjg59@xxxxxxxxxxxxx>
>
> The kexec_load() syscall permits the loading and execution of arbitrary
> code in ring 0, which is something that lock-down is meant to prevent. It
> makes sense to disable kexec_load() in this situation.
>
> This does not affect kexec_file_load() syscall which can check for a
> signature on the image to be booted.

Maybing I am missing it but I am not seeing anything that would require
kexec_file_load be configured such that it checks the loaded kernel.

Without that I don't see the point of disabling kexec_load.

Nacked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>


Eric




> Signed-off-by: Matthew Garrett <mjg59@xxxxxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> Acked-by: Dave Young <dyoung@xxxxxxxxxx>
> Reviewed-by: "Lee, Chun-Yi" <jlee@xxxxxxxx>
> Reviewed-by: James Morris <james.l.morris@xxxxxxxxxx>
> cc: kexec@xxxxxxxxxxxxxxxxxxx
> ---
>
> kernel/kexec.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index aed8fb2564b3..1553ac765e73 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -199,6 +199,13 @@ static inline int kexec_load_check(unsigned long nr_segments,
> if (!capable(CAP_SYS_BOOT) || kexec_load_disabled)
> return -EPERM;
>
> + /*
> + * kexec can be used to circumvent module loading restrictions, so
> + * prevent loading in that case
> + */
> + if (kernel_is_locked_down("kexec of unsigned images"))
> + return -EPERM;
> +
> /*
> * Verify we have a legal set of flags
> * This leaves us room for future extensions.